Fix refs with relative paths pointing outside current dir #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes resolving refs like '../a/b.json'. The main issue here was that `URI.join(base_uri, other)` (called inside json_schemer) needs a path ending with a slash otherwise it does not treat the dirname as a path fragment.
ahx
force-pushed
the
fix-ref-resolver-relative-paths
branch
from
47ff023 to
b23206e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes resolving refs like '../a/b.json'.
The main issue here was that
URI.join(base_uri, other), which is called inside json_schemer, needs a path ending with a slash otherwise it does not treat the dirname as a path fragment.Related to #313