Merge pull request #319 from ahx/global-json-schemer-config

Add support for custom JSONSchemer configuration
ahx · Jan 22, 2025 · ce2d556 · ce2d556
2 parents 140c53f + 81f5100
commit ce2d556
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 4 deletions.
diff --git a/lib/openapi_first/builder.rb b/lib/openapi_first/builder.rb
@@ -18,10 +18,10 @@ def self.build_router(contents, filepath:, config:)
     end
 
     def initialize(contents, filepath:, config:)
-      @schemer_configuration = JSONSchemer::Configuration.new(
-        meta_schema: detect_meta_schema(contents, filepath),
-        insert_property_defaults: true
-      )
+      @schemer_configuration = JSONSchemer.configuration.clone
+      @schemer_configuration.meta_schema = detect_meta_schema(contents, filepath)
+      @schemer_configuration.insert_property_defaults = true
+
       @config = config
       @contents = RefResolver.for(contents, dir: filepath && File.dirname(filepath))
     end

diff --git a/spec/definition_spec.rb b/spec/definition_spec.rb
@@ -159,6 +159,48 @@ def build_request(path, method: 'GET')
         expect(validated.operation_id).to eq('showPetById')
       end
     end
+
+    context 'with customized global JSONSchemer configuration' do
+      before do
+        JSONSchemer.configure do |config|
+          config.formats = { 'pete' => ->(instance, _format) { instance == 'pete' } }
+        end
+      end
+
+      let(:definition) do
+        OpenapiFirst.parse({
+                             'openapi' => '3.1.0',
+                             'paths' => {
+                               '/' => {
+                                 'post' => {
+                                   'requestBody' => {
+                                     'content' => {
+                                       'application/json' => {
+                                         'schema' => {
+                                           'type' => 'string',
+                                           'format' => 'pete'
+                                         }
+                                       }
+                                     }
+                                   }
+                                 }
+                               }
+                             }
+                           })
+      end
+
+      it 'uses the global configuration' do
+        request = Rack::Request.new(Rack::MockRequest.env_for('/', method: 'POST', input: '"bob"', 'CONTENT_TYPE' => 'application/json'))
+        expect(
+          definition.validate_request(request)
+        ).not_to be_valid
+
+        request = Rack::Request.new(Rack::MockRequest.env_for('/', method: 'POST', input: '"pete"', 'CONTENT_TYPE' => 'application/json'))
+        expect(
+          definition.validate_request(request, raise_error: true)
+        ).to be_valid
+      end
+    end
   end
 
   describe '#validate_response' do