Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic cmarkit to mrkdwn converter #3

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

tatchi
Copy link
Contributor

@tatchi tatchi commented Mar 18, 2024

This adds a basic conversion from markdown (Cmarkit.Doc.t) to the mrkdwn syntax.

It's not complete, but at least it's a start and something we can iterate on

@sewenthy
Copy link
Contributor

just curious, why do you prefer this implementation to the one here? the latter seems more complete and have no extra dependency. cc @Khady

@Khady
Copy link
Collaborator

Khady commented Mar 19, 2024

the existing one actually depends on omd. I think that cmarkit is the new standard. Long term we should probably move to it?

@sewenthy
Copy link
Contributor

Okay, LGTM--thanks!

@sewenthy sewenthy merged commit 6950a3f into ahrefs:master Mar 19, 2024
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants