Support for Wrokspace Folders + embedded projects #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LSP clients can have more than one workspace folder, which can be added via [`workspace/didChangeWorkspaceFolders`](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didChangeWorkspaceFolders). This is especially useful for resource-hungry clients, like rust-analyzer or haskell-language-server, in order to avoid spawning multiple clients. Using `lsp.Client.config.root_dir` as the source of truth results in this plugin detecting the wrong project root in this scenario. This PR fixes that, by first searching through the `lsp.Client.workspace_folder`s, and then falling back to the `config.root_dir` if no matching workspace folder is found.
…mbedded in another + unit tests
This was referenced Jan 7, 2025
Closed
ro0gr
reviewed
Jan 8, 2025
| describe('M._get_buf_root()):', function() | ||
| it("testing M._get_buf_root() returns correct buf_root for embedded projects", function() | ||
| local outter_project = "/Users/kkrime/outter_project" | ||
| local inner_project = "/Users/kkrime/outter_project/inner_project" |
There was a problem hiding this comment.
unsure if it really matters, but it seems some more universal paths like /tmp/outer_project could work better
There was a problem hiding this comment.
It really doesn't make any difference, you can change it you feel strongly about it, no problem with me
kkrime
force-pushed
the
corner_case_embedded_projects
branch
from
72c6c5b to
c11869a
Compare
kkrime
force-pushed
the
corner_case_embedded_projects
branch
from
c11869a to
a6a0763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.