Rephrasing documentation for clariry. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nic-agoda
approved these changes
Jul 3, 2023
|
Hi @virasak, what is remaining for me to get approval from a maintainer? :) |
dicko2
reviewed
Jul 6, 2023
README.md
Outdated
|
|
||
| **_Username and hostname are collected as a part of build information_** | ||
| Dotnet Build Metrics is a custom MSBuild task that measures the time to build each project and publishes the information to a datastore. The intent is to measure and improve developer experience on local workstations. |
There was a problem hiding this comment.
I think it's gone beyond this. We also have Web server startup time and the test data collection in the repo now.
I think the "build time" I would rephrase (for dotnet) to "the F5 experience". Because it's commonly known to dotnet developers that F5 is the should cut ket to debug your application.
The other part is test run data collection.
Overall the goal is around measuring and improving developer local experience
There was a problem hiding this comment.
I see, It feels like the base work needed more than just rephrasing.
Let me rework that.
|
Updated the documentation using your input. Hope like it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
I have rephrased the documentation to emphasize the installation process.
Please let me know if you find it more suitable.
RL