Stateless models #1976
Open
Stateless models #1976
+1,458
−1,889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashpreetbedi
commented
Feb 2, 2025
| def set_functions(self, functions: Dict[str, Function]) -> None: | ||
| self._functions = functions | ||
|
|
||
| # @staticmethod |
There was a problem hiding this comment.
keeping around just in case, will be deleted once this PR is ready
dirkbrnd
reviewed
Feb 4, 2025
dirkbrnd
reviewed
Feb 4, 2025
dirkbrnd
reviewed
Feb 4, 2025
dirkbrnd
reviewed
Feb 4, 2025
| @@ -238,60 +204,6 @@ def _get_function_calls_to_run( | |||
| function_calls_to_run.append(_function_call) | |||
| return function_calls_to_run | |||
|
|
|||
| def add_tool( | |||
There was a problem hiding this comment.
Gemini will need a refactor, since it has a custom add_tools
dirkbrnd
reviewed
Feb 4, 2025
| if self.tool_choice is None: | ||
| request_params["tool_choice"] = "auto" | ||
| else: | ||
| if self.tool_choice is not None: |
There was a problem hiding this comment.
aren't you missing auto as a default here?
dirkbrnd
reviewed
Feb 4, 2025
libs/agno/agno/models/groq/groq.py
Outdated
|
|
||
| # -*- Generate response | ||
| metrics.start_response_timer() | ||
| assistant_message.metrics.start_timer() |
dirkbrnd
reviewed
Feb 4, 2025
libs/agno/agno/models/groq/groq.py
Outdated
| metrics.completion_tokens += 1 | ||
| if metrics.completion_tokens == 1: | ||
| metrics.time_to_first_token = metrics.response_timer.elapsed | ||
| assistant_message.metrics.completion_tokens += 1 |
There was a problem hiding this comment.
Should this not use the completion tokens from the response? I always thought this was weird, because a delta isn't necessarily one token right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please check the options that are relevant: