Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Mockery v3 yaml #92

Closed
wants to merge 15 commits into from
Closed

feat: use Mockery v3 yaml #92

wants to merge 15 commits into from

Conversation

temaniarpit27
Copy link
Contributor

Description

Include mockery yaml file for generating mocks

Fixes # (issue)

#74

@temaniarpit27 temaniarpit27 marked this pull request as ready for review January 1, 2025 07:37
@temaniarpit27 temaniarpit27 changed the title Mockery config feat: use Mockery v3 yaml Jan 1, 2025
Stefan-Ethernal
Stefan-Ethernal approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, leaving a comment to consider.

sync/driver.go Show resolved Hide resolved
@temaniarpit27 temaniarpit27 mentioned this pull request Jan 6, 2025
Open
rachit77
rachit77 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@rachit77 rachit77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@temaniarpit27 temaniarpit27 requested a review from a team January 9, 2025 14:28
@temaniarpit27 temaniarpit27 enabled auto-merge (squash) January 9, 2025 14:34
@temaniarpit27 temaniarpit27 mentioned this pull request Jan 9, 2025
Merged
auto-merge was automatically disabled January 9, 2025 14:48

Pull request was closed

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Stefan-Ethernal Stefan-Ethernal deleted the arpit/74 branch January 13, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@rachit77 rachit77 rachit77 approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@temaniarpit27 @rachit77 @Stefan-Ethernal