Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove aggregator #72

Merged
merged 13 commits into from
Dec 31, 2024
Merged

feat: remove aggregator #72

merged 13 commits into from
Dec 31, 2024

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Dec 26, 2024

Description

Removed aggregator from aggkit

Fixes #53.

@rachit77 rachit77 self-assigned this Dec 26, 2024
@rachit77 rachit77 marked this pull request as draft December 26, 2024 11:13
@rachit77 rachit77 marked this pull request as ready for review December 26, 2024 12:18
@Stefan-Ethernal Stefan-Ethernal linked an issue Dec 26, 2024 that may be closed by this pull request
@Stefan-Ethernal Stefan-Ethernal changed the base branch from main to develop December 26, 2024 13:04
@rachit77 rachit77 force-pushed the rachit77/remove-aggregator branch 2 times, most recently from aee8be6 to 6100927 Compare December 30, 2024 08:17
config/config.go Show resolved Hide resolved
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we need to remove/make some more adjustments:

  • aggkit/scripts/local_config

    Lines 183 to 191 in 13b2291

    export_key_from_toml_file_or_fatal zkevm_aggregator_port $_CDK_CONFIG_FILE Aggregator Port
    export_key_from_toml_file zkevm_l2_agglayer_address $_CDK_CONFIG_FILE Aggregator SenderAddress
    if [ $? -ne 0 ]; then
    export_key_from_toml_file zkevm_l2_agglayer_address $_CDK_CONFIG_FILE "." SenderProofToL1Addr
    fi
    export_obj_key_from_toml_file zkevm_l2_aggregator_keystore_password $_CDK_CONFIG_FILE Aggregator.EthTxManager PrivateKeys Password
    if [ $? -ne 0 ]; then
    export_key_from_toml_file zkevm_l2_aggregator_keystore_password $_CDK_CONFIG_FILE "." AggregatorPrivateKeyPassword
    fi
  • cdk-aggregator:
    container_name: cdk-aggregator
    image: aggkit
    ports:
    - 50081:50081
    - 9093:9091 # needed if metrics enabled
    environment:
    - CDK_AGGREGATOR_DB_HOST=cdk-aggregator-db
    - CDK_AGGREGATOR_SENDER_ADDRESS=0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
    volumes:
    - ./config/test.config.toml:/app/config.toml
    - ./config/test.genesis.json:/app/genesis.json
    - ./aggregator.keystore:/pk/aggregator.keystore
    command:
    - "/bin/sh"
    - "-c"
    - "/app/aggkit run --cfg /app/config.toml --network custom --custom-network-file /app/genesis.json --components aggregator"
    depends_on:
    cdk-aggregator-db:
    condition: service_started
    aggkit-l1-sync-db:
    condition: service_started
    cdk-aggregator-db:
  • zkevm_l2_aggregator_address: "0xfC419a9d9Fe0DfA4Cf9971AcD1Fbcd356DD768FD"
    zkevm_l2_aggregator_private_key: "0xa70db9fb4b84a6ba18c03cd2266116dd110538d6c4c88e67ca35a29b910da25d"

crates/aggkit/src/config_render.rs Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal force-pushed the rachit77/remove-aggregator branch from 10cdfa5 to d7eddaa Compare December 31, 2024 10:40
@goran-ethernal goran-ethernal merged commit d820b9a into develop Dec 31, 2024
7 of 12 checks passed
@goran-ethernal goran-ethernal deleted the rachit77/remove-aggregator branch December 31, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the aggregator from aggkit
3 participants