Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple pessimistic proofs e2e tests #105

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Jan 13, 2025

Description

The branch jhilliard/multi-pp-testing that was used for multiple pessimistic proofs testing is removed from the Kurtosis CDK and the changes are merged to the main branch (0xPolygon/kurtosis-cdk#401). Update the Kurtosis CDK ref to use the main branch.

Fixes #106

@Stefan-Ethernal Stefan-Ethernal changed the title ci: use main branch for kurtosis cdk fix: multiple pessimistic proofs e2e tests Jan 13, 2025
@Stefan-Ethernal Stefan-Ethernal linked an issue Jan 13, 2025 that may be closed by this pull request
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jan 13, 2025
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/multi-pp-e2e-tests branch 3 times, most recently from 9617755 to ddd6500 Compare January 14, 2025 09:01
@Stefan-Ethernal Stefan-Ethernal enabled auto-merge (squash) January 15, 2025 08:23
@Stefan-Ethernal Stefan-Ethernal merged commit 0e1883c into develop Jan 15, 2025
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/multi-pp-e2e-tests branch January 15, 2025 08:35
@@ -138,18 +128,10 @@ jobs:
with:
repository: 0xPolygon/kurtosis-cdk
path: kurtosis-cdk
ref: jhilliard/multi-pp-testing
ref: main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin a version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

I'll create a separate PR for that, because the v0.2.26 on the Kurtosis CDK was created in a meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple pessimistic proofs e2e test is failing
4 participants