WebVoyager Baseline Agent & Benchmark #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alckasoc
added
enhancement
alckasoc
commented
Feb 2, 2025
| response = self.generate_thought(messages=messages, seed=seed) | ||
| prompt_tokens = response.prompt_tokens | ||
| completion_tokens = response.completion_tokens | ||
| gpt_4v_res = response.output_text |
There was a problem hiding this comment.
we arent using openai specifically. use the LLM class
| }, | ||
| ) | ||
|
|
||
| def reset( ######## Fix documentation ############# |
There was a problem hiding this comment.
are u absolutely sure there is no state within this agent?
| Returns: | ||
| Response: The generated output text from the model. | ||
| """ | ||
| response = self.llm(messages, max_tokens=max_tokens, seed=seed, timeout=timeout) |
There was a problem hiding this comment.
structure this into _prompt_* functions
Comment on lines
+171
to
+179
| self, | ||
| system_prompt: str, | ||
| system_prompt_text_only: str, | ||
| seed: int, | ||
| max_attached_imgs: int, | ||
| temperature: float, | ||
| text_only: bool, | ||
| task: Dict[str, Any], | ||
| obs: Dict[str, Any] |
There was a problem hiding this comment.
some of these are hyperparameters. some of them are parameters for the generate method. some of them shouldnt even be parameters
There was a problem hiding this comment.
system prompts should never need to be passed in (refer to all the agents we've implemented thus far)
also doesn't this baseline webvoyager agent have a state? it keeps a history of all the messages. doesn't it? does your implementation consider that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Reasoning
Explain the purpose of this PR...
🚧 Changes
Describe the changes made...
✅ PR Checklist