Remove code duplication of agda-mode #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve of this, I think I was indeed to quick to accept the original PR. |
jespercockx
approved these changes
Dec 6, 2023
odderwiser
pushed a commit
to odderwiser/agda2hs
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Jesper Cockx <[email protected]>
odderwiser
pushed a commit
to odderwiser/agda2hs
that referenced
this pull request
Dec 25, 2023
Co-authored-by: Jesper Cockx <[email protected]>
viktorcsimma
pushed a commit
to viktorcsimma/agda2hs
that referenced
this pull request
Dec 28, 2023
Co-authored-by: Jesper Cockx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the duplication originating in #198.
As discussed in # 7012 of the Agda issue tracker, there is no need to duplicate all the Emacs-related code from the
agda/agdarepo; instead one can simply change the binary Emacs uses (I myself do it automatically using direnv and some custom variable initialisation elisp code in my.emacs).@viktorcsimma Does this make sense or am I missing an advantage to copy-pasting this code in our repo?
@jespercockx As the reviewer of the original commit, WDYT?