-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functors between (co)cone categories #448
Conversation
Beside the location of the above functors, I also wasn't to certain about the naming scheme for them. I simply took the existing names and replaced
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nitpick, and this is good to go, at least code-wise.
{ F₀ = F-map-Coconeˡ | ||
; F₁ = F-map-Cocone⇒ˡ | ||
; identity = λ {A} → G.identity | ||
; homomorphism = λ {X} {Y} {Z} {f} {g} → G.homomorphism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here (and everywhere in this PR), can you delete implicits if/when they are not needed please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I've removed all implicit arguments from the lambdas in my commit.
On names: I wonder if |
6b69c6c
to
6af1a53
Compare
I agree; maybe it would still be preferrable to include |
I admit that I was thinking of the usage as having |
Fine for me, too. This would have the advantage of making the order of words canonical ( Edit: so if you want me to rename things to |
This adds three functors between cone categories (and cocone categories, respectively). All F₀ and F₁ fields are maps that already have been defined in Categories.Diagram.Co(co)ne.Properties, and thus the Functor definition is places there as well. Unfortunately, using the definition of Cones (and Cocones) requires the import of Categories.Category.Construction.Cones (and Cocones) in the Cones.Properties module. For `F : Functor J C`, the new functors are: - Every `G : Functor C D` lifts to a `Functor (Cones F) (Cones (G ∘F F))` and `Functor (Cocones F) (Cocones (G ∘F F))` - Every `G : Functor J′ J` lifts to a `Functor (Cones F) (Cones (F ∘F G))` and `Functor (Cocones F) (Cocones (F ∘F G))` - Every `G : Functor J C` and `α : NaturalTransformation F G` extends to a `Functor (Cones F) (Cones G)` and `Functor (Cocones G) (Cocones F)` In Cocones.Properties, I've restricted the import of Cone.Properties to the four maps that are actually used.
6af1a53
to
4fd67ee
Compare
I've just renamed the functions to |
Thanks for approving this PR! Is there anything left that I can (or need to) do? |
No, I just needed to let the checks run to completion before I could merge (and then I got insanely busy). Merging now. |
This adds three functors between cone categories (and cocone categories, respectively). All F₀ and F₁ fields are maps that already have been defined in Categories.Diagram.Co(co)ne.Properties, and thus the Functor definition is places there as well. Unfortunately, using the definition of Cones (and Cocones) requires the import of
Categories.Category.Construction.Cones (and Cocones) in the Cones.Properties module.
For
F : Functor J C
, the new functors are:G : Functor C D
lifts to aFunctor (Cones F) (Cones (G ∘F F))
andFunctor (Cocones F) (Cocones (G ∘F F))
(from Contribution of lemmas about colimits #417)G : Functor J′ J
lifts to aFunctor (Cones F) (Cones (F ∘F G))
andFunctor (Cocones F) (Cocones (F ∘F G))
G : Functor J C
andα : NaturalTransformation F G
extends to aFunctor (Cones F) (Cones G)
andFunctor (Cocones G) (Cocones F)
In Cocones.Properties, I've restricted the import of Cone.Properties to the four maps that are actually used.