Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New D-Bus API #70

Merged
merged 186 commits into from
Mar 15, 2022
Merged

New D-Bus API #70

merged 186 commits into from
Mar 15, 2022

Conversation

imobachgs
Copy link
Contributor

This PR merges the changes related to the new D-Bus API, including the adapted user interface.

It includes #26, #30, #31, #34, #36, #37, #38, #42, #43, #45, #46, #47, #48, #49, #50, #53, #54, #55, #56, #57, #58, #59, #60, #62, #63, #65, #66, #67 and #69.

jreidinger and others added 30 commits February 16, 2022 10:43
initial new dbus service code
Synchronize new-dbus-api with master
imobachgs and others added 26 commits March 14, 2022 09:52
Replace the Singleton pattern with Dependency Injection
Add an API to listen for changes
It's not a final solution, but it slightly helps to cover up flickering
problems with login screen. Flickering itself still there, but at least
the content it's different / meaningful by now.
Do not crash when asking for available_devices
Add a class to handle network settings
* Unify backend/frontend work in the same workflow, so code
  coverage from both sides is grouped.
Add RSpec infrastructure
@imobachgs imobachgs merged commit 99e23fa into master Mar 15, 2022
@imobachgs imobachgs deleted the new-dbus-api branch March 15, 2022 15:39
@coveralls
Copy link

coveralls commented Mar 15, 2022

Pull Request Test Coverage Report for Build 1987675747

  • 147 of 948 (15.51%) changed or added relevant lines in 48 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-79.9%) to 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/dinstaller.rb 0 1 0.0%
web/src/context/installer.jsx 0 1 0.0%
web/src/main.jsx 0 1 0.0%
web/src/lib/client/index.js 1 3 33.33%
web/src/lib/client/software.js 9 11 81.82%
web/src/DBusError.jsx 0 3 0.0%
web/src/lib/client/language.js 7 11 63.64%
service/lib/dinstaller/dbus/storage.rb 0 5 0.0%
service/lib/dinstaller/errors.rb 0 5 0.0%
service/lib/dinstaller/storage.rb 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
web/src/InstallationProgress.jsx 2 0%
Totals Coverage Status
Change from base Build 1946763959: -79.9%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants