feat(web): UI for editing partition #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
reviewed
Feb 18, 2025
| if (mountPoint !== initialMountPoint && mountPoints.includes(mountPoint)) { | ||
| return { | ||
| id: "mountPoint", | ||
| message: _("Select or enter a mount point that is not already assigned to another device"), |
There was a problem hiding this comment.
Not for this iteration, but I’d like to offer the user the "implicit move action" at this point. Of course, we’ll need to implement richer validations for it. Additionally, we should provide the information we already know, such as the device to which the mount point is currently assigned.
joseivanlopez
force-pushed
the
storage-edit-partition
branch
from
43211ce to
d9fcfd1
Compare
joseivanlopez
force-pushed
the
storage-edit-partition
branch
from
d9fcfd1 to
59985db
Compare
joseivanlopez
force-pushed
the
storage-edit-partition
branch
from
b547d9c to
4ba4032
Compare
dgdavid
approved these changes
Feb 20, 2025
Comment on lines
+240
to
+241
| const filesystemButton = screen.getByRole("button", { name: "File system" }); | ||
| within(filesystemButton).getByText("XFS"); |
There was a problem hiding this comment.
A note for whoever could be interested: these lines reveal we are using a not fully accessible component for selects. Something to be fixed in the future, or not. Depends on team/developers priorities.
joseivanlopez
merged commit 1341c0d
into
agama-project:storage-config-ui
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the "edit partition" button to navigate to the partiton page, and the partition page is adapted to allow editing a partition.