feat(web): UI for adding a partition #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
storage-add-partition
branch
3 times, most recently
from
36d8c61 to
4372ca3
Compare
Pull Request Test Coverage Report for Build 13030708832Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
joseivanlopez
force-pushed
the
storage-add-partition
branch
12 times, most recently
from
b6db50c to
3494183
Compare
- Now the list of volumes is properly cached.
Lost while deleting all previous CSS during the migration to PF6. I.e., related to - agama-project#1900 - agama-project#1921 - agama-project#1954 - agama-project#1961
To improve clarity, the size field now spans two rows, providing more space for explanations. Texts were changed to the ones agreed with @ancorgs. Additionally, reusable interface wrapper components have been introduced to avoid code duplication here and there when using style modifiers. An icon to grab the user's attention has been added before the auto-size explanation, which can be replaced with a more suitable one once a better option is found.
Instead of having them sticky to the bottom of the viewport.
Needed for testing components making use of url params for retrieving resources based on them. The whole react-router-dom shoudl be re-worked, starting by using a data router. See https://reactrouter.com/6.29.0/routers/picking-a-router#using-v64-data-apis
As it happens in native HTML form inputs. Still work to do for polishing it.
joseivanlopez
force-pushed
the
storage-add-partition
branch
from
093de29 to
83be3b6
Compare
A quite generic test for at least ensuring it renders expected controls. Some of these components deserves specific unit tests for testing its specific behavior, but out of the scope of this commit. To make things a bit better, some aria-labels have been added. But the whole form still need quite some work for making it much more accessible. Last but not least, the commit also address an issue with the "Clear mount point" button and add a test for it.
By mocking useConfigModel properly, which now lives in queries/storag/config-model instead of queries/storage. The component code has been refactored a bit too.
By updating some hook mocks locations.
To stop using a section and make it more consistent with partitions form. It also stop using the sticky footer for the form actions since it is not an endless form like the language or keyboard selection
|
|
Instead of using comples translation for joining complex sentences.
- For example, if a partition already exists in the model as effect of using the custom policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI for adding new partitions to a drive config or for reusing an existing partition. Allows defining the mount point, the target (a new partition or use an existing one), the file system type (or reuse the existing file system) and a size range.
The size can be autocalculated, informing to the user about the size range used by the installer.