Remove unused width and height properties from flat and standard shaders #5647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
flat
andstandard
shaders both list awidth
andheight
property. These properties go unused and can thus be removed. Originally they seemed to have been used for video textures to indicate the dimensions of the video element, however this is no longer the case. The only reference I could find was in a material unit test.This PR simply removes the properties. A good indicator that it isn't needed might be the
phong
shader which never had them to begin with, but supports video textures in the same way asflat
andstandard
do.Changes proposed:
width
andheight
properties fromflat
andstandard
shaders