Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused width and height properties from flat and standard shaders #5647

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Jan 27, 2025

Description:
The flat and standard shaders both list a width and height property. These properties go unused and can thus be removed. Originally they seemed to have been used for video textures to indicate the dimensions of the video element, however this is no longer the case. The only reference I could find was in a material unit test.

This PR simply removes the properties. A good indicator that it isn't needed might be the phong shader which never had them to begin with, but supports video textures in the same way as flat and standard do.

Changes proposed:

  • Remove width and height properties from flat and standard shaders

@dmarcos
Copy link
Member

dmarcos commented Jan 27, 2025

Thanks

@dmarcos dmarcos merged commit e839a50 into aframevr:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants