Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preghpages/ghpages commands to use recent versions #5627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vincentfretin
Copy link
Contributor

Description:
Update preghpages/ghpages commands to use recent versions without vulnerabilities.
Before:

39 vulnerabilities (14 moderate, 21 high, 4 critical)

After:

24 vulnerabilities (9 moderate, 13 high, 2 critical)

I tested npm run preghpages before and after, there is no change to the gh-pages folder produced.

Similar change also done in aframe-inspector repo: aframevr/aframe-inspector#785

Changes proposed:

  • Remove shx dependency that should have been removed when we moved from browserify to webpack
  • Replace ghpages -p folder by gh-pages -d folder that does exactly the same thing. ghpages is a non maintained wrapper over gh-pages
  • Update replace-in-file package used in the scripts/preghpages.js script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant