Remove misspelled and deprecated getComputedAttrib #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrxz
force-pushed
the
remove-get-computed-attribut
branch
from
084526c to
34c93ab
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Encountered this misspelled method in
a-scene.js. Since it was intended to provide a deprecation message to those using the oldgetComputedAttributemethod, there's little use in fixing the spelling or keeping it around. It's highly unlikely that someone started using this misspelled variant (due to the deprecation warning it logs), so it should be safe to remove.Changes proposed:
getComputedAttrib