Remove epsilon for scale as Three.js handles zero scale #5404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Three.js gracefully handles objects with zero scale for quite a while now (mrdoob/three.js#17926, mrdoob/three.js#18885). As a result it's no longer needed for A-Frame to use an epsilon value to prevent scale from becoming zero along any or all axes.
For the animation component this also allows the animation to go from positive to negative or vice versa, which is currently prevented.
Changes proposed:
scale
oranimation
component)