PR feedback

Previous attempt didn't preserve this in forEach() callback. This version should work better (while still only using ES5 constructs).
aframevr · Nov 5, 2023 · 6217b74 · 6217b74
1 parent b9d3133
commit 6217b74
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/components/hand-tracking-controls.js b/src/components/hand-tracking-controls.js
@@ -187,7 +187,9 @@ module.exports.Component = registerComponent('hand-tracking-controls', {
       if (!controller || !this.mesh) { return; }
       this.mesh.visible = false;
       if (!this.hasPoses) { return; }
-      controller.hand.values().forEach(function (inputjoint) {
+      var inputjoints = controller.hand.values();
+      for (var i = 0; i < inputjoints.length; i++) {
+        var inputjoint = inputjoints[i];
         var bone = this.getBone(inputjoint.jointName);
         if (bone != null) {
           this.mesh.visible = true;
@@ -196,7 +198,7 @@ module.exports.Component = registerComponent('hand-tracking-controls', {
           bone.quaternion.setFromRotationMatrix(jointPose);
         }
         i++;
-      });
+      }
     };
   })(),