Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to bevy 0.13 #109

Merged
merged 8 commits into from
Feb 23, 2024
Merged

update to bevy 0.13 #109

merged 8 commits into from
Feb 23, 2024

Conversation

aevyrie
Copy link
Owner

@aevyrie aevyrie commented Feb 18, 2024

No description provided.

Copy link
Contributor

@RobWalt RobWalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll append some small cleanup-like commits to my CI-fix PR which resolve all of my own review comments here so feel free to ignore them.

* fix(tests): QueryFilter fixed to be in filter position

Authored-by: RobWalt <[email protected]>

* chore(cleanup): remove unneeded `Mesh::from`

Authored-by: RobWalt <[email protected]>

* chore(cleanup): use Direction3D API directly

Ok to be fair this doesn't change a lot. It saves one indirection
through the `TryFrom` trait which might even gets optimized away in the
first place. Nevertheless it is a bit more explicit which will help
newer people to understand the code and develop good habits.

Authored-by: RobWalt <[email protected]>
@aevyrie aevyrie merged commit 81f4c90 into main Feb 23, 2024
5 checks passed
@aevyrie aevyrie deleted the bevy-0.13 branch February 23, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants