Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Transaction stats 2 #618

Merged
merged 11 commits into from
Jan 8, 2024
Merged

feat: Transaction stats 2 #618

merged 11 commits into from
Jan 8, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Dec 12, 2023 •
edited
Loading

Description

Resolves #447

Demo

image
image

Checklist:

@janmichek janmichek mentioned this pull request Dec 12, 2023
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Deployed to https://pr-618-aescan.stg.service.aepps.com

@janmichek janmichek force-pushed the Transactions-stats branch 2 times, most recently from d4fb451 to 35b317a Compare December 14, 2023 15:45
Liubov-crypto
Liubov-crypto suggested changes Dec 29, 2023
View reviewed changes
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that TRANSACTIONS IN LAST 24H is not updating at all:

2023-12-29.5.51.50.mov

@janmichek please check it.

Also I found additional issue with zoom on mobile, will register it separately cuz it's also reproducible on product.

@janmichek
Copy link
Collaborator Author

It seems that TRANSACTIONS IN LAST 24H is not updating at all

Interesting, I cannot confirm the same issue. Maybe there was some downtime at the moment you were reviewing it. If it appears repeatedly, I will investigate and report it.

@Liubov-crypto
Copy link

It seems that TRANSACTIONS IN LAST 24H is not updating at all

Interesting, I cannot confirm the same issue. Maybe there was some downtime at the moment you were reviewing it. If it appears repeatedly, I will investigate and report it.

@janmichek still not working for me, I've tried in different browsers. Also no visible issues in console.

@michele-franchi
Copy link
Collaborator

@Liubov-crypto could you check again?

Liubov-crypto
Liubov-crypto approved these changes Jan 4, 2024
View reviewed changes
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it's working, LGTM

@janmichek janmichek merged commit 5161569 into develop Jan 8, 2024
2 checks passed
@janmichek janmichek deleted the Transactions-stats branch January 8, 2024 03:24
@janmichek janmichek mentioned this pull request Jan 8, 2024
Closed
@janmichek
Copy link
Collaborator Author

improvement followup, noticed after the merge #646

@aeternity-bot aeternity-bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto approved these changes

@michele-franchi michele-franchi Awaiting requested review from michele-franchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transactions stats
3 participants
@janmichek @Liubov-crypto @michele-franchi