docs: add transaction types to enum #2091
Conversation
docs/swagger_v3/contracts.spec.yaml
Outdated
| @@ -21,7 +21,7 @@ schemas: | |||
| source_tx_hash: | |||
| $ref: '#/components/schemas/TransactionHash' | |||
| source_tx_type: | |||
| type: string | |||
| $ref: '#/components/schemas/TransactionType' | |||
There was a problem hiding this comment.
I propose doing it more accurately by specifying only possible values. For example, a contract can't be created by a spend transaction.
There was a problem hiding this comment.
Oh I see. I'll look into it
| @@ -141,3 +141,33 @@ components: | |||
| required: | |||
| - next | |||
| - prev | |||
| TransactionType: | |||
There was a problem hiding this comment.
is it possible to use something like $ref: '#/components/schemas/Tx/allOf/0/properties/type' instead?
There was a problem hiding this comment.
I was looking for something like that. I'll use it
| @@ -180,8 +180,7 @@ schemas: | |||
| items: | |||
| $ref: '#/components/schemas/Signature' | |||
| tx: | |||
| type: object | |||
| # TODO: define properties | |||
| $ref: '#/components/schemas/Tx' | |||
There was a problem hiding this comment.
As far as I know, it can be only name claim, contract call, contract deploy (?)
Doing as you propose, TypeScript will ask the developer to go over every transaction type (not necessary).
There was a problem hiding this comment.
So make it like the TransactionType should be and add only the possible ones?
resolves: #2082