This repository was archived by the owner on Dec 5, 2019. It is now read-only.
[WIP] Deprecate getRoles function due to naming #78
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a function User#getRoles. This does not follow
the recommended naming convention for C# and does not follow the
naming conventions for the rest of the functions in the SDKs.
There is also a public field exposed on an instance of User named
Roles. This is not readonly and can be overwritten by an end user,
it exposes the list of roles that the user contains.
This change deprecates the function User#getRoles and recommends
to instead use the property Roles. It also refactors Roles from a
field into a readonly property without changing the return type
that the end user expects.
This means, apart from Roles no longer being modifiable for an end
user (which they shouldn't be doing anyway), the change is backwards
compatible.