Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tomcat 9.0.98 / release as 1.2.5 / update github-actions #21

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

SerhatG
Copy link
Member

@SerhatG SerhatG commented Jan 7, 2025

No description provided.

@SerhatG SerhatG requested a review from Hilbrand January 7, 2025 12:55
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Java 11 to compile is not necessary. It can use Java 17 to compile for Java 11 code. Preferable the other pr setting snapshot version should be merged before this (Although technically it doesn't have a related to this change it seems nicer to first set it to snapshot version).

@SerhatG SerhatG changed the title [github-actions] Update to v1.2 and also update actions/checkout to v4 Update to tomcat 9.0.98 / release as 1.2.5 / update github-actions Jan 8, 2025
@SerhatG
Copy link
Member Author

SerhatG commented Jan 8, 2025

I've included an update to the version number and also updated Tomcat to the latest version while we're at it.
The other PR is outdated, and can't be merged without fixing conflicts.

@SerhatG SerhatG requested a review from Hilbrand January 8, 2025 09:49
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerhatG SerhatG merged commit b0002ad into aerius:main Jan 8, 2025
1 check passed
@SerhatG SerhatG deleted the github_actions_update branch January 8, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants