update dependency on libp2p from 0.14.4 to 0.38.1 #327
Conversation
|
The branch from #328 can be merged together with this one into a new branch to run the sync test So both can be tested at the same time |
I will rebase my commits on #328 and add some more fixes. The default security policy of libp2p looks stronger, so it prevent connection to node of old versions of libp2p. |
|
There found critical backward incompatibility in libp2p-v0.32.1. I will try to apply intermediate version for smooth upgrade. This PR will be closed, and I will make new PR. |
|
So this means that the update will be made via 2 releases? |
|
Maybe, or not. I reviewed the libp2p source and decided that there was no way to make the security layer optional. So, at first, the idea was to release an intermediate version that optionally supported the security layer, wait for all nodes accessing the public chain to be replaced with that release, and then release a new version with a current libp2p that requires only security layer. But, I found some intercepter interfaces of libp2p after that. Today, I plan to investigate that intercepters a little more to see if there is a way to control security settings. If this is possible, it would likely be possible with one release. |
hayarobi
force-pushed
the
feature/updateLibP2P
branch
2 times, most recently
from
8bb7de5 to
ca26f63
Compare
- Fixed code that was not backward compatible due to the interface change. - Fixed failed unit tests. - Regenerate mock classes with newer gomock version. - Improved documents of code generations of mock classes.
hayarobi
force-pushed
the
feature/updateLibP2P
branch
from
ca26f63 to
43484a6
Compare
| @@ -7,7 +7,7 @@ package transport | |||
|
|
|||
| import ( | |||
| "context" | |||
| secio "github.com/libp2p/go-libp2p-secio" | |||
| "github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoremem" | |||
There was a problem hiding this comment.
maybe this line can be moved down, together with the others of libp2p
| @@ -10,7 +10,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/aergoio/aergo/v2/types" | |||
| core "github.com/libp2p/go-libp2p-core" | |||
| core "github.com/libp2p/go-libp2p/core" | |||
| @@ -1,6 +1,7 @@ | |||
| package p2p | |||
|
|
|||
| import ( | |||
| "github.com/libp2p/go-libp2p/core/crypto" | |||
There was a problem hiding this comment.
this can be moved down, together with similar imports
| @@ -9,7 +9,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/aergoio/aergo/v2/p2p/p2pcommon" | |||
| core "github.com/libp2p/go-libp2p-core" | |||
| core "github.com/libp2p/go-libp2p/core" | |||
There was a problem hiding this comment.
core no longer needed at the left
hayarobi
changed the title
|
Time has passed. During that time, golang has been released twice more version to 1.23. And, libp2p has also been released up to 0.38.1. If this branch is sync with develop, the commit graph becomes too cluttered and difficult to read. So I rebased this branch based on the develop branch. |
=== commit message