feat(modifiers): add support for namespace modifier to allow rest par…

…ameters (#115) feat #105
adzejs · Apr 1, 2022 · 509d3dd · 509d3dd
1 parent 6c7efb1
commit 509d3dd
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/demo_funcs.js b/demo_funcs.js
@@ -319,6 +319,8 @@ function withNamespace({ adze }) {
 function withMultiNamespace({ adze }) {
   console.log('\n----- Default Multiple Namespace Log w/ No Store -----\n');
   adze().ns(['foo', 'bar']).info('This log has multiple namespaces.');
+  adze().namespace('foo', 'bar', 'baz').info('Testing multiple namespaces using rest parameters.');
+  adze().ns('foo', 'bar', 'baz').info('Testing multiple namespaces using rest parameters with the ns() alias.');
 }
 
 function withTime({ adze }) {

diff --git a/src/log/BaseLog.ts b/src/log/BaseLog.ts
@@ -586,9 +586,11 @@ export class BaseLog {
    *
    * This is a non-standard API.
    */
-  public namespace(ns: string | string[]): this {
+  public namespace(ns: string[]): this;
+  public namespace(...rest: string[]): this;
+  public namespace(ns: string | string[], ...rest: string[]): this {
     return this.modifier((ctxt) => {
-      ctxt._namespaceVal = isString(ns) ? [ns] : ns;
+      ctxt._namespaceVal = isString(ns) ? [ns, ...rest] : ns;
     });
   }
 
@@ -597,8 +599,10 @@ export class BaseLog {
    *
    * This is a non-standard API.
    */
-  public ns(ns: string | string[]): this {
-    return this.namespace(ns);
+  public ns(ns: string[]): this;
+  public ns(...rest: string[]): this;
+  public ns(ns: string | string[], ...rest: string[]): this {
+    return this.namespace(ns as string, ...rest);
   }
 
   /**

diff --git a/test/browser/modifiers/identifying.ts b/test/browser/modifiers/identifying.ts
@@ -37,3 +37,13 @@ test('log with multiple namespaces prints correctly', (t) => {
     t.fail();
   }
 });
+
+test('log with multiple namespaces using rest parameters prints correctly', (t) => {
+  const { render } = adze().ns('test', 'test2').log('This log has a label.');
+  if (render) {
+    const [_, args] = render;
+    t.is(args[2], '#test #test2 ');
+  } else {
+    t.fail();
+  }
+});
diff --git a/test/node/modifiers/identifying.ts b/test/node/modifiers/identifying.ts
@@ -32,3 +32,13 @@ test('log with multiple namespaces prints correctly', (t) => {
     t.fail();
   }
 });
+
+test('log with multiple namespaces using rest parameters prints correctly', (t) => {
+  const { render } = adze().ns('test', 'test2').log('This log has a label.');
+  if (render) {
+    const [_, args] = render;
+    t.is(args[1], '#test #test2 ');
+  } else {
+    t.fail();
+  }
+});