Adding support for 'minified' parameter when fetching a library's items #3945
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
This PR attempts to fix the issue where the
/api/libraries/<id>/itemsendpoint only returns minified library items.Which issue is fixed?
Fixes #2123
In-depth Description
This endpoint currently just maps all library items
toOldJSONMinified()regardless of theminifiedparameter sent in the request. This change checks the parameter and maps to either the minified, or thetoOldJSONExpanded().How have you tested this?
Tested by running locally through API test client with both response prior, and response after (with
minified=1) and then withminified=0.Also verified that change didn't affect web / mobile clients
Screenshots
n/a