Skip to content

OpenZeppelin Contracts's GovernorVotesQuorumFraction updates to quorum may affect past defeated proposals

High severity GitHub Reviewed Published Jul 28, 2022 in OpenZeppelin/openzeppelin-contracts • Updated Jan 30, 2023

Package

npm @openzeppelin/contracts (npm)

Affected versions

>= 4.3.0, < 4.7.2

Patched versions

4.7.2
npm @openzeppelin/contracts-upgradeable (npm)
>= 4.3.0, < 4.7.2
4.7.2

Description

Impact

This issue concerns instances of Governor that use the module GovernorVotesQuorumFraction, a mechanism that determines quorum requirements as a percentage of the voting token's total supply. In affected instances, when a proposal is passed to lower the quorum requirement, past proposals may become executable if they had been defeated only due to lack of quorum, and the number of votes it received meets the new quorum requirement.

Analysis of instances on chain found only one proposal that met this condition, and we are actively monitoring for new occurrences of this particular issue.

Patches

This issue has been patched in v4.7.2.

Workarounds

Avoid lowering quorum requirements if a past proposal was defeated for lack of quorum.

References

OpenZeppelin/openzeppelin-contracts#3561

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at [email protected].

References

@frangio frangio published to OpenZeppelin/openzeppelin-contracts Jul 28, 2022
Published by the National Vulnerability Database Aug 1, 2022
Published to the GitHub Advisory Database Aug 18, 2022
Reviewed Aug 18, 2022
Last updated Jan 30, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
High
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N

EPSS score

0.062%
(29th percentile)

Weaknesses

CVE ID

CVE-2022-31198

GHSA ID

GHSA-xrc4-737v-9q75

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.