Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add influence classification for ConnectivityTracer #78

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 21, 2024

  • Revamp ConnectivityTracer to follow the blueprint of GradientTracer, except that it uses is_influence instead of is_firstder
  • Add a new category of operators whose influence is zero, and distinguish them from those who have an influence but zero derivatives
  • Handle big, widen, zero, one, oneunit, typemin, typemax, eps, float, floatmin, floatmax, maxintfloat like normal 1_to_1 operators when they are applied to numbers (not when they are applied to types)
  • Add special case for when ForwardDiff cannot compute derivatives (we assume those derivatives are zero)

@gdalle gdalle requested a review from adrhill May 21, 2024 08:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 79.19%. Comparing base (efefcc7) to head (b3b2335).

Files Patch % Lines
src/operators.jl 57.69% 11 Missing ⚠️
src/overload_connectivity.jl 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   77.30%   79.19%   +1.88%     
==========================================
  Files          14       14              
  Lines         617      644      +27     
==========================================
+ Hits          477      510      +33     
+ Misses        140      134       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/overload_connectivity.jl Outdated Show resolved Hide resolved
test/classification.jl Outdated Show resolved Hide resolved
test/classification.jl Outdated Show resolved Hide resolved
test/classification.jl Outdated Show resolved Hide resolved
@gdalle gdalle requested a review from adrhill May 21, 2024 16:52
Copy link
Owner

@adrhill adrhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@adrhill adrhill merged commit d0f64cf into main May 21, 2024
4 checks passed
@adrhill adrhill deleted the gd/merge_ops branch May 21, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants