Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conj, real, transpose, adjoint on numbers #75

Merged
merged 7 commits into from
May 21, 2024
Merged

Add conj, real, transpose, adjoint on numbers #75

merged 7 commits into from
May 21, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 19, 2024

Fix #73

Needs tests

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (d0f64cf) to head (4f0b377).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   75.44%   76.03%   +0.59%     
==========================================
  Files          14       14              
  Lines         676      676              
==========================================
+ Hits          510      514       +4     
+ Misses        166      162       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill
Copy link
Owner

adrhill commented May 21, 2024

Is this now tested with #76?

@adrhill
Copy link
Owner

adrhill commented May 21, 2024

Feel free to merge a minor PR like this one on your own when it's ready.

@gdalle
Copy link
Collaborator Author

gdalle commented May 21, 2024

The operators themselves will be tested but not the dot product which was our aim. I'll add something to that effect

@gdalle gdalle requested a review from adrhill May 21, 2024 17:25
test/first_order.jl Outdated Show resolved Hide resolved
@adrhill adrhill merged commit c49dc32 into main May 21, 2024
4 checks passed
@adrhill adrhill deleted the gd/conj branch May 21, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dot products
3 participants