Skip to content

Commit

Permalink
Remove version conditionals <1.10
Browse files Browse the repository at this point in the history
  • Loading branch information
adrhill committed Oct 9, 2024
1 parent 1081b0a commit 3ff7750
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 17 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ jobs:
- Core
- Benchmarks
- NLPModels
exclude: # TODO: remove once LTS is not 1.6
- version: 'lts'
group: NLPModels
- version: 'lts'
group: Benchmarks
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand Down
19 changes: 7 additions & 12 deletions test/test_arrays.jl
Original file line number Diff line number Diff line change
Expand Up @@ -311,14 +311,11 @@ end
testJ1(SpdiagmifyInput(exp), v)
testH1(SpdiagmifyInput(exp), v)

if VERSION >= v"1.10"
# issue with custom _mapreducezeros in SparseArrays on Julia 1.6
testJ0(SpdiagmifyInput(pow0), v)
testH0(SpdiagmifyInput(pow0), v)
testJ0(SpdiagmifyInput(pow0), v)
testH0(SpdiagmifyInput(pow0), v)

testJ1(SpdiagmifyInput(pow3), v)
testH1(SpdiagmifyInput(pow3), v)
end
testJ1(SpdiagmifyInput(pow3), v)
testH1(SpdiagmifyInput(pow3), v)
end
end

Expand All @@ -327,11 +324,9 @@ end
testJ1(pinv, A)
testH1(pinv, A)
end
if VERSION >= v"1.9"
@testset "`SparseMatrixCSC` (3×4)" begin
testJ1(SparsifyInput(pinv), rand(3, 4))
testH1(SparsifyInput(pinv), rand(3, 4))
end
@testset "`SparseMatrixCSC` (3×4)" begin
testJ1(SparsifyInput(pinv), rand(3, 4))
testH1(SparsifyInput(pinv), rand(3, 4))
end
end

Expand Down

0 comments on commit 3ff7750

Please sign in to comment.