Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on false negatives if repro_compare.sh is run after comparable_patch.sh in ReproducibleBuilds.md #4123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

warn on false negatives if repro_compare.sh is run after comparable_patch.sh in ReproducibleBuilds.md #4123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d352951
warn on false negatives if repro_compare.sh is run after comparable_…
judovana Jan 31, 2025
619fe40
Removed trailing space
judovana Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tooling/reproducible/ReproducibleBuilds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ The patching process involves:
- Remove any non-deterministic build process artifact strings, like Manifest Created-By stamps.
- Zero out CRC in .gnu_debuglink ELF sections to eliminate .debuginfo-induced differences.

**warning:** If you run `comparable_patch.sh`, do not use `repro_compare.sh` for final comparison. You would get false negatives. Run plain `diff jdk1 jdk2` with any switches you need.

### How to setup and run comparable_patch.sh on Windows

#### Tooling setup:
Expand Down
Loading