Automate API check for updates #4869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automate API check for updates Check if update is available in Artifactory for any JDK version
jdekonin
reviewed
Dec 19, 2023
| def CHILD_JOB_NAME="JCK_Sync" | ||
| def BUILD_URL="${JENKINS_URL}job/${CHILD_JOB_NAME}/" | ||
| def CHILD_PARAMS = [] | ||
| def JCK_GIT_REPO = "[email protected]:runtimes/JCK${key}-unzipped.git" |
There was a problem hiding this comment.
The script is also used by other vendors (e.g. Adoptium), not only ibm, so the link repo cannot be hardcoded. Suggest a root location be passed into the script (jenkins env var) and JCK_GIT_REPO be constructed.
| #!/bin/bash | ||
|
|
||
| # File to store the previous state | ||
| PREVIOUS_STATE_FILE="/home/jenkins/previous_state.txt" |
There was a problem hiding this comment.
Shouldn't assume that the system where this would be run will have a /home/jenkins folder. If appropriate, would the use of ${WORKSPACE} be better? Or maybe setting to the location of the script if the file is only intended for temporary use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate API check for updates
Check if update is available in Artifactory for any JDK version and trigger sync job to update repository.