Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way to add GPG key #2459

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Correct way to add GPG key #2459

merged 1 commit into from
Dec 14, 2023

Conversation

ecspresso
Copy link
Contributor

using /etc/apt/keyrings is deprecated, see https://manpages.debian.org/testing/apt/apt-key.8.en.html

Description of change

Updated the documentation on how to add gpg key and install on debian/ubuntu distros.
Using /etc/apt/keyrings is deprecated, see https://manpages.debian.org/testing/apt/apt-key.8.en.html

Checklist

  • documentation is changed or added (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 189adcb
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/655f6d9f52c2c20008b6f1a1
😎 Deploy Preview https://deploy-preview-2459--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karianna
Copy link
Contributor

@ecspresso Are you able to sign the Eclipse CLA?

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19ef97a) 99.20% compared to head (189adcb) 99.20%.
Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6541     6541           
  Branches      552      552           
=======================================
  Hits         6489     6489           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ecspresso
Copy link
Contributor Author

@ecspresso Are you able to sign the Eclipse CLA?

How do I check this?

I was able to add the key, update and install without any error messages.

@smlambert
Copy link
Contributor

Eclipse Foundation Contributor's Agreement (ECA), details here: https://adoptium.net/docs/eca-sign-off/

@xavierfacq
Copy link
Member

@ecspresso 👋 Any news from you ? Do you have created an account for the Eclipse Foundation Contributor ?

@ecspresso
Copy link
Contributor Author

ecspresso commented Dec 14, 2023

Hello again, I have created an account and signed the Eclipse Contributor Agreement.

Most the email used for my Eclipse account as my public email on Github?

EDIT: I have two accounts on github, one is public and I used the other one on Eclipse. Cannot seem to change it there as well.

@xavierfacq xavierfacq merged commit 191777c into adoptium:main Dec 14, 2023
3 checks passed
@ecspresso ecspresso deleted the patch-1 branch December 14, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants