Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare peer dependency on @ember/string for compatibility with Ember >= 5 #359

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Declare peer dependency on @ember/string for compatibility with Ember >= 5 #359

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3acc3e4
declare peer dependency on @ember/string
jelhan Nov 7, 2024
8d8af09
add test scenarios for Ember v4.12 and v5.4
jelhan Nov 7, 2024
450fd25
Update package.json
jelhan Nov 7, 2024
97905a4
update lockfile
jelhan Nov 7, 2024
61c06a1
regenerate lockfile with pinned NPM version
jelhan Nov 7, 2024
a3f9e49
Merge branch 'master' into declare-peer-dependency-on-ember-string
SergeAstapov Nov 8, 2024
d2697c4
update lockfile
SergeAstapov Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ jobs:
- ember-lts-3.20
- ember-lts-3.24
- ember-lts-3.28
- ember-lts-4.12
- ember-lts-5.4
- ember-release
- ember-beta
- ember-canary
Expand Down
16 changes: 16 additions & 0 deletions config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,22 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0',
},
},
},
{
name: 'ember-lts-5.4',
npm: {
devDependencies: {
'ember-source': '~5.4.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down
Loading
Loading