-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(mwpw-161843): favicon is loaded fast. #3530
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3530 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 274 274
Lines 61849 61849
=======================================
Hits 59705 59705
Misses 2144 2144 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Validation done on the pr after the fix , favicon is seen loaded faster now https://main--dc--adobecom.hlx.live/acrobat?milolibs=mwpw-161843--milosh--sharath-kannan |
Skipped 3530: "Fix(mwpw-161843): favicon is loaded fast." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
The Favicon icon is loaded post LCP
Resolves: MWPW-161843
Test URLs: