Fix DC converter widget block unit tests #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsayAdobe
added
trivial
TsayAdobe
requested review from
peller,
saragajic11,
draganatrajkovic,
kbenelli-adobe,
zagi25 and
JFernandezAdobe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #508 +/- ##
==========================================
+ Coverage 97.90% 99.00% +1.10%
==========================================
Files 26 26
Lines 2907 2907
==========================================
+ Hits 2846 2878 +32
+ Misses 61 29 -32 ☔ View full report in Codecov by Sentry. |
peller
reviewed
Dec 16, 2023
| <div>https://www.adobe.com/go/testredirect</div> | ||
| </div> | ||
| <div> | ||
| <div>https://www.adobe.com/generate_cache_url</div> |
There was a problem hiding this comment.
@peller We can revisit the design. If the feature is not used and will never be used, we should remove the related code.
JFernandezAdobe
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests and do a cleanup