Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-140457 add *.adobe.io to frame-src for downloads #507

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

@peller peller requested a review from TsayAdobe December 13, 2023 01:06
Copy link

aem-code-sync bot commented Dec 13, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aef124) 97.89% compared to head (d188ff5) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #507   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          26       26           
  Lines        2897     2898    +1     
=======================================
+ Hits         2836     2837    +1     
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peller peller changed the title add *.adobe.io to frame-src for downloads MWPW-140457 add *.adobe.io to frame-src for downloads Dec 13, 2023
Copy link
Collaborator

@TsayAdobe TsayAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.adobe.io or *.adobe.com?

@peller
Copy link
Collaborator Author

peller commented Dec 13, 2023

*.adobe.io or *.adobe.com?

adobe.io

@TsayAdobe TsayAdobe merged commit 8cbe699 into stage Dec 14, 2023
4 of 7 checks passed
@joaquinrivero
Copy link
Collaborator

joaquinrivero commented Dec 14, 2023

@peller If we are changing from ". amazonaws.com" domain to ". adobe.io". , amazonaws.com needs to be removed in some point?

@peller
Copy link
Collaborator Author

peller commented Dec 14, 2023 via email

@Blainegunn Blainegunn deleted the acp-downloads branch August 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants