Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-139059 Issue with styling and privacy string #506

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

joaquinrivero
Copy link
Collaborator

Changes Made:

  • Content policies added to dev, stage & prod

How to Test:

  1. Open a milo form.
  2. Verify that the form's styling is now consistent with the production version: Production Form.
  3. Confirm that the privacy strings have been removed

Screenshots:

Before
Screenshot 2023-12-12 at 3 14 20 PM
After
Screenshot 2023-12-12 at 3 15 02 PM

Resolves: MWPW-139059

Test URLs:

Before: https://main--dc--adobecom.hlx.page/drafts/rivero/faas-milo
After: https://mwpw-139699--dc--adobecom.hlx.page/drafts/rivero/faas-milo

Copy link

aem-code-sync bot commented Dec 12, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 12, 2023

Page Scores Audits Google
/drafts/rivero/faas-milo Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aef124) 97.89% compared to head (bb91ca7) 97.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #506   +/-   ##
=======================================
  Coverage   97.89%   97.90%           
=======================================
  Files          26       26           
  Lines        2897     2906    +9     
=======================================
+ Hits         2836     2845    +9     
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquinrivero joaquinrivero changed the title MWPW-139059 - Issue with styling and privacy string MWPW-139059 Issue with styling and privacy string Dec 12, 2023
@TsayAdobe TsayAdobe requested a review from zagi25 December 14, 2023 16:02
@TsayAdobe TsayAdobe merged commit 4347fab into stage Dec 14, 2023
5 of 6 checks passed
@TsayAdobe TsayAdobe deleted the MWPW-139699 branch July 20, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants