MWPW-138943 POC Integration test #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+11
to
+48
| ) => new Promise((resolve) => { | ||
| const el = document.querySelector(selector); | ||
|
|
||
| if (el) { | ||
| resolve(el); | ||
| return; | ||
| } | ||
| if (el) { | ||
| resolve(el); | ||
| return; | ||
| } | ||
|
|
||
| const observer = new MutationObserver((mutations, obsv) => { | ||
| mutations.forEach((mutation) => { | ||
| const nodes = [...mutation.addedNodes]; | ||
| nodes.some((node) => { | ||
| if (node.matches && node.matches(selector)) { | ||
| if (textContent && node.textContent !== textContent) return false; | ||
|
|
||
| const observer = new MutationObserver((mutations, obsv) => { | ||
| mutations.forEach((mutation) => { | ||
| const nodes = [...mutation.addedNodes]; | ||
| nodes.some((node) => { | ||
| if (node.matches && node.matches(selector)) { | ||
| if (textContent && node.textContent !== textContent) return false; | ||
| obsv.disconnect(); | ||
| resolve(node); | ||
| return true; | ||
| } | ||
|
|
||
| // check for child in added node | ||
| const treeWalker = document.createTreeWalker(node); | ||
| let { currentNode } = treeWalker; | ||
| while (currentNode) { | ||
| if (currentNode.matches && currentNode.matches(selector)) { | ||
| obsv.disconnect(); | ||
| resolve(node); | ||
| resolve(currentNode); | ||
| return true; | ||
| } | ||
|
|
||
| // check for child in added node | ||
| const treeWalker = document.createTreeWalker(node); | ||
| let { currentNode } = treeWalker; | ||
| while (currentNode) { | ||
| if (currentNode.matches && currentNode.matches(selector)) { | ||
| obsv.disconnect(); | ||
| resolve(currentNode); | ||
| return true; | ||
| } | ||
| currentNode = treeWalker.nextNode(); | ||
| } | ||
| return false; | ||
| }); | ||
| currentNode = treeWalker.nextNode(); | ||
| } | ||
| return false; | ||
| }); | ||
| }); | ||
|
|
||
| observer.observe(rootEl, options); | ||
| }); | ||
|
|
||
| observer.observe(rootEl, options); | ||
| }); |
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all
Comment on lines
+56
to
+62
| ) => new Promise((resolve) => { | ||
| const observer = new MutationObserver((mutations, obsv) => { | ||
| obsv.disconnect(); | ||
| resolve(); | ||
| }); | ||
| observer.observe(el, options); | ||
| }); |
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all
Comment on lines
+70
to
+93
| ) => new Promise((resolve) => { | ||
| const el = document.querySelector(selector); | ||
|
|
||
| if (!el) { | ||
| resolve(); | ||
| return; | ||
| } | ||
| if (!el) { | ||
| resolve(); | ||
| return; | ||
| } | ||
|
|
||
| const observer = new MutationObserver((mutations, obsv) => { | ||
| mutations.forEach((mutation) => { | ||
| const nodes = [...mutation.removedNodes]; | ||
| nodes.some((node) => { | ||
| if (node.matches(selector)) { | ||
| obsv.disconnect(); | ||
| resolve(); | ||
| return true; | ||
| } | ||
| return false; | ||
| }); | ||
| const observer = new MutationObserver((mutations, obsv) => { | ||
| mutations.forEach((mutation) => { | ||
| const nodes = [...mutation.removedNodes]; | ||
| nodes.some((node) => { | ||
| if (node.matches(selector)) { | ||
| obsv.disconnect(); | ||
| resolve(); | ||
| return true; | ||
| } | ||
| return false; | ||
| }); | ||
| }); | ||
|
|
||
| observer.observe(el.parentElement, options); | ||
| }); | ||
|
|
||
| observer.observe(el.parentElement, options); | ||
| }); |
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all
Comment on lines
+101
to
+105
| export const delay = (timeOut, cb) => new Promise((resolve) => { | ||
| setTimeout(() => { | ||
| resolve((cb && cb()) || null); | ||
| }, timeOut); | ||
| }); |
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all
Comment on lines
+115
to
129
| return new Promise((resolve, reject) => { | ||
| if (predicate()) resolve(); | ||
|
|
||
| const intervalId = setInterval(() => { | ||
| if (predicate()) { | ||
| clearInterval(intervalId); | ||
| resolve(); | ||
| } | ||
| }, interval); | ||
|
|
||
| setTimeout(() => { | ||
| resolve((cb && cb()) || null); | ||
| }, timeOut); | ||
| clearInterval(intervalId); | ||
| reject(new Error('Timed out waiting for predicate to be true')); | ||
| }, timeout); | ||
| }); |
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise is not supported in op_mini all
| }); | ||
| } |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #496 +/- ##
==========================================
+ Coverage 97.86% 97.90% +0.03%
==========================================
Files 26 26
Lines 2907 2907
==========================================
+ Hits 2845 2846 +1
+ Misses 62 61 -1 ☔ View full report in Codecov by Sentry. |
TsayAdobe
requested review from
JFernandezAdobe,
zagi25,
saragajic11,
NadiiaSokolova,
draganatrajkovic and
puruadobe
JFernandezAdobe
approved these changes
Dec 12, 2023
saragajic11
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
Tu run integration tests on Chromium only:
To run integration tests on 3 browsers: