fix: add try-catch block to authentication manager #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blefebvre
approved these changes
Aug 19, 2024
packages/spacecat-shared-http-utils/src/auth/authentication-manager.js
Outdated
Show resolved
Hide resolved
| @@ -46,6 +46,7 @@ export default class ScopedApiKeyHandler extends AbstractHandler { | |||
| this.log(`No API key entity found in the data layer for the provided API key: ${apiKeyFromHeader}`, 'error'); | |||
| return null; | |||
| } | |||
| this.log(`API Key entity: ${apiKeyEntity}`, 'debug'); | |||
There was a problem hiding this comment.
Should this object be stringified?
There was a problem hiding this comment.
Removing these logs as we might not need them anymore.
|
This PR will trigger a patch release when merged. |
…nager.js Co-authored-by: Bruce Lefebvre <[email protected]>
Yes. Added the additional test case to fix the test errors. |
adobe-bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
# [@adobe/spacecat-shared-http-utils-v1.6.7](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-http-utils-v1.6.6...@adobe/spacecat-shared-http-utils-v1.6.7) (2024-08-19) ### Bug Fixes * add try-catch block to authentication manager ([#336](#336)) ([a6cf629](a6cf629))
|
🎉 This issue has been resolved in version @adobe/spacecat-shared-http-utils-v1.6.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Add try-catch block to authentication-manager to try and figure out the issue with ScopedApiKeyHandler