feat: Pages with steady decline of conversion #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereje24
changed the title
|
This PR will trigger a minor release when merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 8 commits
August 14, 2024 11:40
added 14 commits
August 19, 2024 16:29
ramboz
reviewed
Aug 21, 2024
There was a problem hiding this comment.
I'd rename the file to reflect the exact use case you handle. we'll likely have many opportunity implementations down the road
Comment on lines
75
to
76
| // Initialize a Set to hold the unique selectors for this bundle | ||
| let uniqueSelectors = new Set(); | ||
| const uniqueSelectors = new Set(); |
There was a problem hiding this comment.
I'd move the declaration outside of the loop so you re-use the same variable and avoid allocation of hundreds of different ones.
let uniqueSelectors;
for (const bundle of bundles) {
// Initialize a Set to hold the unique selectors for this bundle
uniqueSelectors = new Set();| let uniqueSelectors = new Set(); | ||
| const uniqueSelectors = new Set(); | ||
|
|
||
| let totalClicks = 0; |
There was a problem hiding this comment.
Same here, I'd move the declaration outside of the loop
| @@ -83,13 +91,13 @@ function handler(bundles) { | |||
|
|
|||
| // Iterate over the unique selectors and increment their count in the global selectors object | |||
| for (const source of uniqueSelectors) { | |||
| globalSelectors[source] = (globalSelectors[source] || 0) + 1; | |||
| const count = uniqueSelectors[source] || 0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!