fix: add fixed status to suggestions #634
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
dzehnder
reviewed
Feb 6, 2025
src/support/utils.js
Outdated
| } finally { | ||
| clearTimeout(id); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
instead of returning null we could return { ok: false } to avoid exceptions
dzehnder
reviewed
Feb 6, 2025
src/support/utils.js
Outdated
Comment on lines
322
to
330
| export const isFixedURL = async (backlink) => { | ||
| try { | ||
| const response = await fetchWithTimeout(backlink.url_to, TIMEOUT); | ||
| return response.ok; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
This might not work for other audits than backlinks right now.
Also we could introduce an expectedStatusCode, for broken backlinks it should be 301 and for sitemap the url is fixed when it is 200.
Suggested change
| export const isFixedURL = async (backlink) => { | |
| try { | |
| const response = await fetchWithTimeout(backlink.url_to, TIMEOUT); | |
| return response.ok; | |
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| } catch (e) { | |
| return false; | |
| } | |
| }; | |
| export const isFixedURL = async (url, expectedStatusCode = 200) => { | |
| try { | |
| const response = await fetchWithTimeout(url, TIMEOUT); | |
| return response.status === expectedStatusCode; | |
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |
| } catch (e) { | |
| return false; | |
| } | |
| }; |
solaris007
reviewed
Feb 6, 2025
| .map(async (suggestion) => { | ||
| const isSuggestionFixed = await isFixed(suggestion); | ||
| if (isSuggestionFixed) { | ||
| suggestion.setStatus(Suggestion.STATUSES.FiXED); |
There was a problem hiding this comment.
it would be better to use Suggestion.bulkUpdateStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we new suggestions are created from a new audit run, we delete the old suggestions that don t reappear from the new audit.
We should check if the old ones are fixed, and mark them as such.