-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save rum-traffic as metrics to s3 #631
Conversation
This PR will trigger a minor release when merged. |
@@ -58,6 +59,7 @@ const HANDLERS = { | |||
'structured-data': structuredData, | |||
'forms-opportunities': formsOpportunities, | |||
'site-detection': siteDetection, | |||
'rum-traffic': rumTraffic, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any preference rum-traffic
vs rum-metrics
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's only about traffic data, not other metrics. Would keep rum-traffic
in that case
@iuliag please review this one: possible overlap with import worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this should be an import, not an audit. please move to import worker
- please make sure you add relevant configurations to global config / jobs dispatcher
getStoredMetrics
should not be part of utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an import of type page-organic-traffic with source rum
and destination default
(meaning S3).
During the workshop, there were 2 discussions leading to the decision to have the metrics collection running independent of the auditing:
- ingestor service for unified metrics collection so that auto-identify and auto-suggest have all kinds of metrics available without duplicating data collection implementation and increasing COGS (see diagram in Experience Success Studio -> ingestor service tab)
- timeline for metrics collection to cover needs of the success report (whiteboarding from workshop)
sure, will move the logic to import worker
is this ingestor service available already? or the future service that we'll implement post GA? If I implement this page-organic-traffic in import worker, will this be ported to ingestor service later?
|
it's not available already. we'll implement it post-GA starting from what we have in the import worker
we have a |
For calculating the projected traffic lost/value, we need organic traffic from RUM for the given page. Rather than each opportunity crunching the RUM data separately, adding this
rum-traffic
audit, which will save the rum-traffic data to importer metrics.So, the opportunities can obtain the rum-traffic data as