feat: introduce auto-suggest for Metatags #608
Conversation
dipratap
changed the title
|
This PR will trigger a minor release when merged. |
dipratap
changed the title
| import { ImsClient } from '@adobe/spacecat-shared-ims-client'; | ||
| import { getSignedUrl } from '@aws-sdk/s3-request-presigner'; | ||
| import { GetObjectCommand } from '@aws-sdk/client-s3'; | ||
| import axios from 'axios'; |
There was a problem hiding this comment.
you must not use axios, but tracingFetch from spacecat-shared-http-utils, which wraps adobe-fetch and performs x-ray tracing.
| const { Configuration } = dataAccess; | ||
| const configuration = await Configuration.findLatest(); | ||
| if (!configuration.isHandlerEnabledForSite('meta-tags-auto-suggest', site)) { | ||
| log.warn('Metatags auto-suggest is disabled for site'); |
| log.error('Metatags Auto-suggest failed: Missing Genvar endpoint or firefall ims orgId'); | ||
| throw new Error('Metatags Auto-suggest failed: Missing Genvar endpoint or firefall ims orgId'); | ||
| } | ||
| const genvarEndpoint = `${context.env.GENVAR_ENDPOINT}/web/aem-genai-variations-appbuilder/metatags`; |
There was a problem hiding this comment.
as GenVar will find re-use across the product, i suggest adding this to spacecat-shared as a generic client, either as part of the gpt client or a new package.
| for (const tagName of ['title', 'description', 'h1']) { | ||
| const tagIssueData = tags[tagName]; | ||
| if (tagIssueData?.aiSuggestion && tagIssueData.aiRationale) { | ||
| // eslint-disable-next-line no-param-reassign |
There was a problem hiding this comment.
please do not re-assign params, use a spread copy instead
| @@ -59,6 +61,8 @@ export async function auditMetaTagsRunner(baseURL, context, site) { | |||
| } | |||
| seoChecks.finalChecks(); | |||
| const detectedTags = seoChecks.getDetectedTags(); | |||
| const healthyTags = seoChecks.getFewHealthyTags(); | |||
| await metatagsAutoSuggest(context, site, { detectedTags, extractedTags, healthyTags }, baseURL); | |||
There was a problem hiding this comment.
this should probably be moved to the audit builder setup below as a post processor item
| const EXPIRY_IN_DAYS = 7 * 24 * 60 * 60; | ||
| const MAX_POLL_RETRIES = 20; | ||
|
|
||
| async function getPresignedUrl(s3Client, log, scrapedData) { |
There was a problem hiding this comment.
can you provide an example what is exactly shared, accessed by whom/what and whether 7 days expiry is necessary?
Meta tags: auto-suggest using GenVar: https://jira.corp.adobe.com/browse/SITES-26415