refactor: standardising opportunityAndSuggestions method #585
+14,700
−26,357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into generalise-opportunity-and-suggestions merge from main
|
This PR will trigger no release when merged. |
…into generalise-opportunity-and-suggestions merge main into generalise-opportunity-and-suggestions
…into generalise-opportunity-and-suggestions merge from main
|
@martinst06 - thanks for your PR! could you add a description to the PR what the purpose and details of your changes are? also the PR title should be |
martinst06
changed the title
solaris007
reviewed
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @alinarublea -
An opportunity data mapper is created for each handler that works with opportunities instead of the data being directly being defined in each handler
Made a standard function for converting to opportunities for the post processor instead of redundantly redefining the same function