fix: React inert prop compatibility #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Dec 13, 2024
| return !!value; | ||
| } | ||
| // compatibility with React < 19 | ||
| return value ? 'true' : undefined; |
There was a problem hiding this comment.
Should this line actually be this?
Suggested change
| return value ? 'true' : undefined; | |
| if value == undefined { | |
| return undefined; | |
| } | |
| return value ? 'true' : 'false'; |
There was a problem hiding this comment.
Yes, this is also how we handled it before. See facebook/react#17157 for more details about the behavior of the inert attribute in React < 19.
snowystinger
previously approved these changes
Dec 16, 2024
# Conflicts: # packages/@react-spectrum/s2/src/Tabs.tsx
snowystinger
approved these changes
Jan 15, 2025
yihuiliao
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7502
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: