Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: initial work to productionize donut #336

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

marshallpete
Copy link
Member

Description

Move some stuff to make it more reusable.
Update opacity rules to account for all highlight conditions.
Remove a bunch of inconsequential tests.
Refactor how data is passed around so it matches existing patterns.
Fix hardcoded id instead of using color field.

Related Issue

#218

Motivation and Context

Donut is still in alpha. This is the initial work for getting donut ready to move out of alpha.

How Has This Been Tested?

Added tests, existing ones are passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

github-actions bot commented Jun 3, 2024

Copy link

sonarqubecloud bot commented Jun 3, 2024

Copy link

github-actions bot commented Jun 3, 2024

@marshallpete marshallpete merged commit c3a2e73 into main Jun 3, 2024
5 checks passed
@marshallpete marshallpete deleted the productionDonut branch June 3, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants