fix(SITES-3057 Accessibility) - Decorative image has non-empty alt attribute. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoianLucian
changed the title
|
failed tests not related to the change |
Pareesh
reviewed
Nov 26, 2024
| @@ -73,6 +73,12 @@ const CardProperty = Decorator(class extends BaseComponent(HTMLElement) { | |||
|
|
|||
| // removes the icon element from the DOM since there is no valid icon. this causes the content to have the | |||
| // correct styling | |||
|
|
|||
| if(this._elements.icon.icon === 'globeRemove') { | |||
| this._elements.icon.removeAttribute('aria-label'); | |||
There was a problem hiding this comment.
Please avoid check related to single icon. The code should be generic and not specified to single icom
There was a problem hiding this comment.
@Pareesh the ticket required to remove the aria label from the specific icon, will check with manager, thank you for the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SITES-3057